Skip to content

fix: proper annotation for patch #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix: proper annotation for patch #2784

merged 1 commit into from
Oct 5, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 5, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner October 5, 2022 05:47
@aeneasr aeneasr mentioned this pull request Oct 5, 2022
3 tasks
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2784 (3f89765) into master (82bc9ce) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2784      +/-   ##
==========================================
- Coverage   75.67%   75.61%   -0.07%     
==========================================
  Files         294      294              
  Lines       17160    17160              
==========================================
- Hits        12986    12975      -11     
- Misses       3184     3192       +8     
- Partials      990      993       +3     
Impacted Files Coverage Δ
identity/handler.go 87.73% <ø> (ø)
courier/courier_dispatcher.go 54.23% <0.00%> (-8.48%) ⬇️
persistence/sql/persister_courier.go 82.82% <0.00%> (-4.05%) ⬇️
persistence/sql/persister.go 72.86% <0.00%> (-1.56%) ⬇️
session/test/persistence.go 98.70% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 0cbfe41 into master Oct 5, 2022
@aeneasr aeneasr deleted the fix-docs-patch branch October 5, 2022 06:22
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant