fix: Preserve return_to param between flows

[mmeller-wikia]

Submitted on behalf of a third-party: fandom.com

This changes fixes redirects for OIDC register/login flows.

Steps to reproduce:

Registration

• Create new account using OIDC provider
• Logout
• Go to some page (allowed for redirect)
• Try to register new account with the same OIDC → you should be logged in and redirected to previous page

Login

• Go to some page (allowed for redirect)
• Try to signin with OIDC (not linked to any user)
• Register new account -> you should be logged in and redirected to previous page

Related issue(s)

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change introduces a new feature.
• I am following the contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security vulnerability.
  If this pull request addresses a security. vulnerability,
  I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have added or changed the documentation.

Further Comments

[CLAassistant]

All committers have signed the CLA.

[mmeller-wikia]

Hi @aeneasr
Can I ask for review?
I think that failing checks are not related to my changes ;)

[aeneasr]

Thank you, great job! Can you please provide a failing test case for the bug you observed to prove that this change is effective?

[codecov]

Codecov Report

Merging #2644 (db8c345) into master (1515b83) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head db8c345 differs from pull request most recent head 05f5c47. Consider uploading reports for the commit 05f5c47 to get more accurate results

@@            Coverage Diff             @@
##           master    #2644      +/-   ##
==========================================
- Coverage   75.26%   75.12%   -0.14%     
==========================================
  Files         294      293       -1     
  Lines       17159    16899     -260     
==========================================
- Hits        12914    12696     -218     
+ Misses       3266     3227      -39     
+ Partials      979      976       -3     

Impacted Files	Coverage Δ
hash/hash_comparator.go	83.15% <0.00%> (-6.25%)	⬇️
x/http_secure_redirect.go	87.75% <0.00%> (-2.73%)	⬇️
selfservice/strategy/link/strategy_verification.go	56.44% <0.00%> (-2.12%)	⬇️
selfservice/strategy/oidc/strategy_login.go	67.53% <0.00%> (-1.39%)	⬇️
persistence/sql/persister_courier.go	84.52% <0.00%> (-0.33%)	⬇️
selfservice/strategy/link/strategy_recovery.go	62.60% <0.00%> (-0.26%)	⬇️
driver/registry_default.go	87.50% <0.00%> (-0.21%)	⬇️
identity/handler.go	87.57% <0.00%> (-0.16%)	⬇️
driver/registry.go	61.11% <0.00%> (ø)
request/builder.go	74.50% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[aeneasr]

Awesome, thank you! 🎉 Your contribution makes Ory better :)

[vinckr]

Hello @mmeller-wikia
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!