Skip to content

Write tests for domain aliasing in cookie handler #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aeneasr opened this issue Apr 28, 2021 · 0 comments · Fixed by #1493
Closed

Write tests for domain aliasing in cookie handler #1292

aeneasr opened this issue Apr 28, 2021 · 0 comments · Fixed by #1493
Assignees
@aeneasr
Labels
feat New feature or request.
Milestone
v0.7.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Apr 28, 2021

Is your feature request related to a problem? Please describe.

See title
@aeneasr aeneasr added the feat New feature or request. label Apr 28, 2021
@aeneasr aeneasr added this to the v0.7.0-alpha.1 milestone Apr 28, 2021
@aeneasr aeneasr self-assigned this Apr 28, 2021
@aeneasr aeneasr mentioned this issue Apr 28, 2021
Closed
31 tasks
aeneasr added a commit to pingiun/kratos that referenced this issue Jul 12, 2021
@aeneasr
chore: code review
11d02a1 
Closes ory#1292
This was referenced Jul 12, 2021
Closed
Merged
aeneasr added a commit that referenced this issue Jul 12, 2021
@pingiun @aeneasr
fix: use session cookie path settings for csrf cookie (#1493)
c6d08ed 
This PR adds configuration option for CSRF cookies and improves the domain alias logic as well as adding tests for it.

Closes #1292
Closes #1493

Co-authored-by: aeneasr <[email protected]>
emkarcinos pushed a commit to Wikia/kratos that referenced this issue Sep 20, 2021
@pingiun @aeneasr @emkarcinos
fix: use session cookie path settings for csrf cookie (ory#1493)
c3ff7fe 
This PR adds configuration option for CSRF cookies and improves the domain alias logic as well as adding tests for it.

Closes ory#1292
Closes ory#1493

Co-authored-by: aeneasr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
feat New feature or request.
Projects
None yet
Milestone
v0.7.0-alpha.1
1 participant
@aeneasr