Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Hydra and Kratos #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Hydra and Kratos #50
Changes from 13 commits
edd2a47
dd37af9
9cd346d
eae1b7d
91e5436
c51b516
4596b92
5a23b10
4e15ca4
10c2d60
634ec3c
6abb329
af0488b
db986b6
067cc28
1a6bbb7
85e9b4d
52f6e05
8b60ab8
0797dcb
c27d922
478e35d
e4bef33
0f0581f
9056a21
987f750
1b96209
9db1e4b
864404d
1efb08c
e3aff58
be226e2
3c4fda7
3bab29b
1c9119a
ce1b787
2331d92
026e2b7
ec2b74f
3c21e68
daf8a7e
662a5ae
750f9f6
cd8284b
d06b655
80915e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
any
is bad practice for typing as it disables typing completely. I think typescript should be smart enough to auto-assert the type here?I am also a bit confused because I would expect this to be:
Which is a shorthand for:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is valid, this should probably be (see comment above):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works, see above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation will be lost after running
npm run format
, you can prevent that with:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a bit confusing when importing this in other routes. How about moving this to a new file
auth.ts
on src?