Skip to content

fix: correct error checking for recovery with mfa return_to #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Jun 29, 2023

Related Issue or Design Document

Fixes regression on a96574d.

This causes incorrect error handling on recovery with mfa with return_to URL.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko Benehiko requested review from jonas-jonas and mszekiel June 29, 2023 12:09
@Benehiko Benehiko requested a review from jonas-jonas June 29, 2023 12:12
@Benehiko Benehiko merged commit 81834a6 into master Jun 29, 2023
@Benehiko Benehiko deleted the fix-kratos-mfa-return-to branch June 29, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants