fix: hide recovery link on refresh #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Benehiko
suggested changes
Jun 21, 2023
src/routes/login.ts
Outdated
Comment on lines
144
to
153
| if (flow.refresh) { | ||
| initRecoveryUrl = getUrlForFlow( | ||
| kratosBrowserUrl, | ||
| "recovery", | ||
| new URLSearchParams({ | ||
| return_to: | ||
| (return_to && return_to.toString()) || flow.return_to || "", | ||
| }), | ||
| ) | ||
| } |
There was a problem hiding this comment.
what happens if we don't refresh the flow at all and we are logging in for the first time? Then the recovery link will be gone right?
There was a problem hiding this comment.
A better way might be to retrieve the session and then check if the user is already logged in. Based on that + refresh true we can hide the recovery link.
We will also need to omit the forgotPasswordURL property from additionalProps in the UserAuthCard function since we don't want to show the link at all.
There was a problem hiding this comment.
Ups, that should be inverted. Thanks!
aeneasr
commented
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ory/kratos#3047
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments