Skip to content

feat: functional integration kratos hydra #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Jorgagu
Copy link
Contributor

@Jorgagu Jorgagu commented May 14, 2023

Functional integration of the hydra consent page after login with the login challenge ID in the query param.

Related Issue or Design Document

#224

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Jorgagu Jorgagu force-pushed the feat/kratos-hydra-integration branch from 8f6f8e8 to 05d9fdb Compare May 14, 2023 22:25
@Jorgagu Jorgagu marked this pull request as ready for review May 14, 2023 22:49
@congngale
Copy link

congngale commented Jun 5, 2023

Hi @Jorgagu

Is this MR is ready to use with Hydra, I would like to use your branch for testing out the integration of Hydra and Kratos.

@Jorgagu
Copy link
Contributor Author

Jorgagu commented Jun 6, 2023

Hi @congngale
You can use my branch for testing based on this exemple here : https://github.com/ory/examples/tree/master/kratos-hydra

@congngale
Copy link

Hi @Jorgagu

I have used latest Kratos v0.13.0 and Hydra v2.1.2 to verify the integration but it did not work as expected. I got error as below:

oauth_error

@aeneasr
Copy link
Member

aeneasr commented Jun 14, 2023

Hi, please use the latest stable version of Hydra, it looks like you're using the release candidate which is not yet compatible with kratos!

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@aeneasr aeneasr merged commit 9a7abdc into ory:master Jun 14, 2023
@Jorgagu Jorgagu deleted the feat/kratos-hydra-integration branch June 14, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants