fix: verification redirect base url #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benehiko
commented
Mar 31, 2023
Comment on lines
+83
to
+85
| const baseUrl = req.path.split("/") | ||
| // get rid of the last part of the path (e.g. "login") | ||
| baseUrl.pop() |
There was a problem hiding this comment.
This is maybe a bit overkill and just a simple res.redirect("verification") might've been suffice. But I added this in case the application was hosted with a base URL added to the router.
There was a problem hiding this comment.
Maybe you could add that comment to the code as well. This will lead to confusion down the future.
jonas-jonas
approved these changes
Mar 31, 2023
Comment on lines
+83
to
+85
| const baseUrl = req.path.split("/") | ||
| // get rid of the last part of the path (e.g. "login") | ||
| baseUrl.pop() |
There was a problem hiding this comment.
Maybe you could add that comment to the code as well. This will lead to confusion down the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirecting to the
/verificationroute with a base URL would cause problems since the redirect would be to the root of the URL and not the base path of the URL.Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments