Skip to content

chore: remove handlebar-helpers #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

chore: remove handlebar-helpers #242

merged 1 commit into from
Jan 31, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Jan 31, 2023 •
edited
Loading

Related Issue or Design Document

This PR removes the unused handlebar-helpers package. We have moved most of the rendering tasks to react-dom/server inside Ory Elements and do not require handlebar-helpers at all.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko Benehiko requested a review from hperl January 31, 2023 16:55
hperl
hperl approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks, this is awesome 🎉

@hperl hperl merged commit 2840e03 into master Jan 31, 2023
@hperl hperl deleted the remove-handlebar-helpers branch January 31, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hperl hperl hperl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benehiko @hperl