Skip to content

feat(preset): add "sparks" sound preset #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 23, 2024
Merged

Conversation

arda-guler
Copy link
Collaborator

Adds a sound preset that short circuits some high voltage lines every time you press keys on your keyboard.

The inspiration is from Google (yuck!) Colab. Somewhere in the settings, there is this "power mode" setting that you can set so that the Colab editor makes sparks as you type, and more sparks as you type faster. I simply thought that the sparks lacked some... excitement, despite all the "shiny" VFX they cause. Audio!

Well, there it is.

coommmet

@arda-guler arda-guler requested a review from orhun as a code owner December 25, 2023 15:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbb6673) 22.63% compared to head (5d35570) 22.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   22.63%   22.63%           
=======================================
  Files          11       11           
  Lines         455      455           
=======================================
  Hits          103      103           
  Misses        352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arda-guler arda-guler added the enhancement New feature or request label Dec 25, 2023
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun changed the title Add "Sparks" sound preset feat(preset): add "sparks" sound preset Mar 23, 2024
@orhun orhun merged commit 5db4bb2 into orhun:main Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants