Will the new GitHub strategy affect giscus?

[Rwagsu]

I saw this on GitHub:
https://github.com/orgs/community/discussions/156818
Will giscus be affected by this strategy at this time?

[laymonage]

As far as I understand, no. The markdown is processed by GitHub's server (using the REST API for previews, and the GraphQL API for existing comments) before it's rendered by giscus, so the following link:

https://github.com/user-attachments/assets/b4c8ec0c-96e1-4550-b6df-16f8cab4243e

becomes:

https://private-user-images.githubusercontent.com/27689196/434176048-b4c8ec0c-96e1-4550-b6df-16f8cab4243e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQ4MTc0NzYsIm5iZiI6MTc0NDgxNzE3NiwicGF0aCI6Ii8yNzY4OTE5Ni80MzQxNzYwNDgtYjRjOGVjMGMtOTZlMS00NTUwLWI2ZGYtMTZmOGNhYjQyNDNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDE2VDE1MjYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE2NDAxOWU1MzYzODFjMTFiNDFmMjI2ODA5MzIwMzY1NzQ2ZGM0MGZlN2ZiNjFkZGYwODJjNjU2Y2Q1MTJjOGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8Uh9DuZlIY4BdvyKAiW0Gp6itW4Z8IVu2Jh5TDhhllo

[Rwagsu]

Thank you, I'm understand now.😄 获取Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: sag​e ***@***.***> Sent: Wednesday, April 16, 2025 11:30:44 PM To: giscus/giscus ***@***.***> Cc: Starcloudsea ***@***.***>; Author ***@***.***> Subject: Re: [giscus/giscus] Will the new GitHub strategy affect giscus? (Discussion #1635) As far as I understand, no. The markdown is processed by GitHub's server (using the REST API for previews<https://docs.github.com/en/rest/markdown/markdown>, and the GraphQL API for existing comments) before it's rendered by giscus, so the following link: https://github.com/user-attachments/assets/b4c8ec0c-96e1-4550-b6df-16f8cab4243e becomes: https://private-user-images.githubusercontent.com/27689196/434176048-b4c8ec0c-96e1-4550-b6df-16f8cab4243e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQ4MTc0NzYsIm5iZiI6MTc0NDgxNzE3NiwicGF0aCI6Ii8yNzY4OTE5Ni80MzQxNzYwNDgtYjRjOGVjMGMtOTZlMS00NTUwLWI2ZGYtMTZmOGNhYjQyNDNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDE2VDE1MjYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE2NDAxOWU1MzYzODFjMTFiNDFmMjI2ODA5MzIwMzY1NzQ2ZGM0MGZlN2ZiNjFkZGYwODJjNjU2Y2Q1MTJjOGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8Uh9DuZlIY4BdvyKAiW0Gp6itW4Z8IVu2Jh5TDhhllo — Reply to this email directly, view it on GitHub<#1635 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUHVSUZX7NZ3MOBHPKWJ3L32ZZZSJAVCNFSM6AAAAAB3IROEKGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEOBVGY3DKMQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>