Skip to content

Improve handling of expired session on the client #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebruchez opened this issue Feb 14, 2023 · 11 comments
Closed

Improve handling of expired session on the client #5678

ebruchez opened this issue Feb 14, 2023 · 11 comments
Assignees

Comments

@ebruchez
Copy link
Collaborator

  • we send 403
  • 401 would be more correct
  • unofficial 440 (used by Microsoft) would be possibly better

+1 from customer

@ebruchez
Copy link
Collaborator Author

ebruchez commented Feb 14, 2023

Assuming we decide to use a 440:

  • server to send a 440 in that case (instead of a 403, currently)
  • when the client detects a 440, do something similar to login page detection (blog)

@ebruchez
Copy link
Collaborator Author

+1 today in relation to #5896.

ebruchez added a commit that referenced this issue Aug 21, 2023
ebruchez added a commit that referenced this issue Aug 21, 2023
@ebruchez ebruchez reopened this Aug 21, 2023
@ebruchez
Copy link
Collaborator Author

ebruchez commented Aug 21, 2023

@ebruchez
Copy link
Collaborator Author

showLoginDetectedDialog() is at XForms level, but new dailog from #5896 is at Form Runner level. Handle using listener.

@ebruchez
Copy link
Collaborator Author

For 2021.1.x and 2022.1.x, we don't need to handle the dialog of #5896 since that's not present on those branches. So we can backport if we'd like.

@ebruchez
Copy link
Collaborator Author

  • dialog can show under Form Builder Publish dialog

@ebruchez
Copy link
Collaborator Author

Deciding to test a little more before including on 2022.1.x. and 2021.1.x.

@ebruchez
Copy link
Collaborator Author

We actually included this in the 2022.1.5 PE release as well.

@ebruchez
Copy link
Collaborator Author

ebruchez commented Nov 29, 2023

  • enter new issue for using the Form Runner dialog

@ebruchez
Copy link
Collaborator Author

Entered #6102 issue as follow-up.

@ebruchez
Copy link
Collaborator Author

Checked that we haven't yet included this in the 2021.1.x series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant