-
Notifications
You must be signed in to change notification settings - Fork 104
chore: update to image-spec v1.1.1
#909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 80.24% 80.19% -0.05%
==========================================
Files 63 63
Lines 6053 6053
==========================================
- Hits 4857 4854 -3
- Misses 858 860 +2
- Partials 338 339 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates documentation and code comments to reference image‑spec v1.1.1 along with related distribution‑spec links. It also adjusts the media type regular expression to reflect the new specification.
- Updated references across comments in various files from v1.1.0 to v1.1.1.
- Modified the mediaTypeRegexp in pack.go to match the new image‑spec.
- Updated documentation links in registry and content packages to point to the new spec versions.
Reviewed Changes
File | Description |
---|---|
pack.go | Updated image‑spec documentation and mediaTypeRegexp |
registry/remote/repository.go | Updated distribution‑spec references |
registry/remote/errcode/errors.go | Updated error code documentation links |
registry/repository.go | Updated image‑spec references in comments |
registry/remote/warning.go | Updated warning reference links |
content/oci/readonlystorage.go | Updated image layout reference |
registry/reference.go | Updated references for pulling manifests |
content/oci/oci.go | Updated image layout references |
registry/remote/registry.go | Updated registry API reference |
example_pack_test.go | Updated image‑spec version reference in test example |
content/oci/storage.go | Updated image layout reference in comments |
content/oci/readonlyoci.go | Updated image layout reference |
registry/remote/referrers.go | Updated referrers API documentation references |
registry/remote/url.go | Updated URLs documentation references |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pack.go:115
- [nitpick] Please verify that the reordering in the mediaTypeRegexp character class accurately reflects the pattern defined in image‑spec v1.1.1 to avoid any unintended matching issues.
var mediaTypeRegexp = regexp.MustCompile(`^[A-Za-z0-9][A-Za-z0-9!#$&^_.+-]{0,126}/[A-Za-z0-9][A-Za-z0-9!#$&^_.+-]{0,126}$`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
image-spec v1.1.1
inpack.go
image-spec v1.1.1
anddistribution-spec v1.1.1
Resolves: #910