feat: option to have File store preserve permissions when extracting #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammy-da
force-pushed
the
file-store-preserve-perms
branch
3 times, most recently
from
9f93f59 to
f9f1baa
Compare
sammy-da
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
sammy-da
force-pushed
the
file-store-preserve-perms
branch
4 times, most recently
from
830c0a9 to
0b55f28
Compare
TerryHowe
reviewed
Feb 14, 2025
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 80.27% 80.19% -0.08%
==========================================
Files 63 63
Lines 6047 6053 +6
==========================================
Hits 4854 4854
- Misses 856 860 +4
- Partials 337 339 +2 ☔ View full report in Codecov by Sentry. |
Wwwsylvia
reviewed
Feb 20, 2025
Wwwsylvia
reviewed
Feb 20, 2025
sammy-da
force-pushed
the
file-store-preserve-perms
branch
2 times, most recently
from
bafe923 to
5560c4d
Compare
Wwwsylvia
requested changes
Feb 21, 2025
sammy-da
force-pushed
the
file-store-preserve-perms
branch
4 times, most recently
from
26443ab to
9bf6f31
Compare
Wwwsylvia
changed the title
Wwwsylvia
reviewed
Feb 24, 2025
shizhMSFT
reviewed
Feb 24, 2025
|
@sammy-da DCO checking is failing. Could you fix it? |
sammy-da
force-pushed
the
file-store-preserve-perms
branch
from
f7118da to
46736fd
Compare
|
@sammy-da Could you help to rebase? |
Signed-off-by: Sammy Abed <[email protected]>
Signed-off-by: Sammy Abed <[email protected]>
sammy-da
force-pushed
the
file-store-preserve-perms
branch
from
0ae429f to
89a8845
Compare
|
@Wwwsylvia rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of #886, or rather part of it.
It adds an option to the File store that's similar to tar's
--preserve-permissions.closes #886