Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Unconsume wasm gas if execute gas less contract #56

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

GNaD13
Copy link
Collaborator

@GNaD13 GNaD13 commented Dec 18, 2024

This PR will:

  • unconsume wasm gas if execute gas less contract

Question: Since we unconsume wasm gas, should we add back cosmos tx gas?

Copy link

@ledanghuy1811 ledanghuy1811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GNaD13
Copy link
Collaborator Author

GNaD13 commented Dec 19, 2024

@ducphamle2, could you check this PR pls, we need this feature for next version.

Copy link
Collaborator

@ducphamle2 ducphamle2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ducphamle2 ducphamle2 merged commit a71c823 into release/v0.50.x Dec 20, 2024
@ducphamle2 ducphamle2 deleted the gas-less-wasmvm branch December 20, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants