pdpdevtool 6104 update thirdparty libraries #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
| const { COLORS, BOLD } = await import('./LoggerFontConstants.mjs'); | ||
| return { COLORS, BOLD }; | ||
| }; | ||
| const LoggerConstants = loadLoggerConstants(); |
There was a problem hiding this comment.
To make the code a tiny bit more readable, I suggest to
rename LoggerConstants to something like LoggerConstantsPromise or LoggerFormatterPromise...
…and separator with getters
Comment on lines
+30
to
+77
| // const mainAnswers = await prompt([ | ||
| // { | ||
| // type: 'list', | ||
| // name: 'type', | ||
| // message: 'What object type would you like to create?', | ||
| // choices: OBJECT_TYPES, | ||
| // }, | ||
| // { | ||
| // type: 'input', | ||
| // name: 'objectfilename', | ||
| // message: (answers_1) => `Please specify the filename for the ${chalk.green.bold(answers_1.type.name)} object`, | ||
| // transformer: (input_1, answers_2, flags) => `${answers_2.type.prefix}${input_1}.xml`, | ||
| // }, | ||
| // { | ||
| // type: 'list', | ||
| // name: 'folder', | ||
| // message: (answers_4) => | ||
| // `Where would you like to store the ${chalk.green.bold(answers_4.type.prefix + answers_4.objectfilename + '.xml')} file?`, | ||
| // choices: objectDirectoryChoices, | ||
| // }, | ||
| // { | ||
| // type: 'confirm', | ||
| // name: 'createrelatedfiles', | ||
| // message: 'Would you like to also create associated files with this object?', | ||
| // when: (answers_6) => answers_6.type.hasRelatedFiles, | ||
| // }, | ||
| // ]); | ||
| // if (mainAnswers.createrelatedfiles) { | ||
| // const fileCabinetDirectoryChoices = this._fileSystemService | ||
| // .getFoldersFromDirectory(join(this._projectFolder, FOLDERS.FILE_CABINET)) | ||
| // .map(transformFoldersToChoicesFunc); | ||
| // const answers_10 = await prompt([ | ||
| // { | ||
| // type: 'input', | ||
| // name: 'relatedfilename', | ||
| // message: 'Please specify the script filename', | ||
| // transformer: (input_3, answers_7, flags) => `${input_3}.js`, | ||
| // }, | ||
| // { | ||
| // type: 'list', | ||
| // name: 'relatedfiledestinationfolder', | ||
| // message: (answers_9) => `Where would you like to store the ${chalk.green.bold(answers_9.relatedfilename)}.js file?`, | ||
| // choices: fileCabinetDirectoryChoices, | ||
| // }, | ||
| // ]); | ||
| // return { ...answers_10, ...mainAnswers }; | ||
| // } | ||
| // return mainAnswers; |
There was a problem hiding this comment.
This doesn't look right to me.
Is this purposeful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.