os-nginx : Add error page file extension support #4687
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemric
changed the title
|
Hi! |
kulikov-a
approved these changes
May 15, 2025
|
Yeah, of course help message could be changed up to you ^^ |
fichtner
reviewed
May 16, 2025
Co-authored-by: Franco Fichtner <[email protected]>
fichtner
reviewed
May 16, 2025
fichtner
reviewed
May 16, 2025
| @@ -1841,6 +1841,10 @@ | |||
| </check001> | |||
| </Constraints> | |||
| </pagecontent> | |||
| <extension type="TextField"> | |||
| <default>html</default> | |||
There was a problem hiding this comment.
although I'm doubting we need a lot of free-text options here?
There was a problem hiding this comment.
do you mean that a drop down list would be better ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #4684
Allow users to change the extension of the error file so we can now set it to i.e. json to make it well read for app that require json
These changes were made on a running Opnsense so perhaps I did miss to report some modifications here, so, please, review it carefully ^^
As I don't know Opnsense code at all I did a "just working" change
see you :)