-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[#64263] Add trial enterprise banner #19045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oliverguenther
merged 9 commits into
dev
from
implementation/64263-add-trial-enterprise-banner
Jun 11, 2025
Merged
[#64263] Add trial enterprise banner #19045
oliverguenther
merged 9 commits into
dev
from
implementation/64263-add-trial-enterprise-banner
Jun 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d91fd9
to
242a435
Compare
242a435
to
9f1b2eb
Compare
cbliard
requested changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I found some blocking issues:
- (half-)wrong upgrade url for "Buy now" button
- in admin > custom fields, the banner is always visible. It should be visible only when hierarchy type is selected.
Other than that it's merely some code comments.
app/controllers/concerns/projects/life_cycle_definition_helper.rb
Outdated
Show resolved
Hide resolved
It's different for Cloud edition and for on-premises.
oliverguenther
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/64263
Notes
EnterpriseToken.allows_to?(:work_package_sharing) || EnterpriseToken.trialling?(:work_package_sharing)
will make sense after the work for multiple tokens is doneOpen points
Works for
Merge checklist