Code for extension install and delete

[LalatenduMohanty]

Here are the commands to test the PR. I used https://github.com/operator-framework/operator-controller/blob/main/config/samples/olm_v1_clusterextension.yaml to create the service-account etc

$ kubectl operator olmv1 install extension argocd --package-name argocd-operator --version 0.6.0 --namespace argocd --service-account argocd-installer
extension "argocd" created

$ kubectl operator olmv1 get extension
NAME    INSTALLED BUNDLE        VERSION  SOURCE TYPE  INSTALLED  PROGRESSING  AGE
argocd  argocd-operator.v0.6.0  0.6.0    Catalog      True       True         65s

$ kubectl operator olmv1 delete extension argocd
deleted extension "argocd"

[LalatenduMohanty]

As discussed with @joelanford and @ankitathomas, not adding the code for CatalogSelector in this PR, we can add this as a follow up.

[anik120]

Looking good mostly @LalatenduMohanty 🎉

[anik120]

As discussed with @joelanford and @ankitathomas, not adding the code for CatalogSelector in this PR, we can add this as a follow up.

By CatalogSelector do you mean source.catalog

Looks like,

  source is a required field which selects the installation source of content
  for this ClusterExtension. Selection is performed by setting the sourceType.

  Catalog is currently the only implemented sourceType, and setting the
  sourcetype to "Catalog" requires the catalog field to also be defined.

will the install command work without this?

[ankitathomas]

/lgtm

[ankitathomas]

Is this a replacement for the global timeout flag?

[LalatenduMohanty]

Right, I continued the catalog create code pattern. Currently the OLMv1 code do not use https://github.com/operator-framework/kubectl-operator/blob/main/internal/cmd/root.go#L36-#L38 global timeout.

[ankitathomas]

Standard kubectl behavior is to treat deleting non-existent resources as a failed operation, except for delete --all. That being said, I'm fine with this to maintain consistency with the current implementation of catalog delete.

[LalatenduMohanty]

Right, I am fine with either way. The catalog and extension create/install uses the same pattern now.

[LalatenduMohanty]

By CatalogSelector do you mean source.catalog

Nope, I am talking about Selector *metav1.LabelSelector in https://github.com/operator-framework/operator-controller/blob/main/api/v1/clusterextension_types.go#L304

// selector is an optional field that can be used
	// to filter the set of ClusterCatalogs used in the bundle
	// selection process.
	//
	// When unspecified, all ClusterCatalogs will be used in
	// the bundle selection process.
	//
	// +optional
	Selector *metav1.LabelSelector `json:"selector,omitempty"`

// There are two different styles of label selectors used in versioned types:
// an older style which is represented as just a string in versioned types, and a
// newer style that is structured.  LabelSelector is an internal representation for the
// latter style.
// A label selector is a label query over a set of resources. The result of matchLabels and
// matchExpressions are ANDed. An empty label selector matches all objects. A null
// label selector matches no objects.
// +structType=atomic
type LabelSelector struct {
	// matchLabels is a map of {key,value} pairs. A single {key,value} in the matchLabels
	// map is equivalent to 
an element of matchExpressions, whose key field is "key", the
	// operator is "In", and the values array contains only "value". The requirements are ANDed.
	// +optional
	MatchLabels map[string]string `json:"matchLabels,omitempty" protobuf:"bytes,1,rep,name=matchLabels"`
	// matchExpressions is a list of label selector requirements. The requirements are ANDed.
	// +optional
	// +listType=atomic
	MatchExpressions []LabelSelectorRequirement `json:"matchExpressions,omitempty" protobuf:"bytes,2,rep,name=matchExpressions"`
}
///

[ankitathomas]

/lgtm