events: include zio type in IO error reports #17381
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
I am making more and varied IO shapes that fail aggressively. This patch is helping me!
Description
Adds
io_type
to error reports.Usually the IO type can be inferred from the other fields (in particular, priority and flags) sometimes it's not easy to see. This is just another little debug helper.
I added descriptions of
zio_type
andzio_priority
tozpool-events.8
as well (the latter because I thought I missed it in an earlier commit, only to find it had nothing to do with me, oh well).How Has This Been Tested?
Used in anger on Linux for a while. Compile checked on FreeBSD just now.
events
test tag passed, though nothing in ZTS actually considers the event output in any depth, so that's not surprising.Types of changes
Checklist:
Signed-off-by
.