Skip to content

Fix null dereference in spa_vdev_remove_cancel_sync() #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Fix null dereference in spa_vdev_remove_cancel_sync() #17361

merged 1 commit into from
May 22, 2025

Conversation

amotin
Copy link
Member

@amotin amotin commented May 21, 2025

We don't really need to access space map to know where the metaslab ends, while msp->ms_sm might be NULL.

Fixes #17164
Fixes #17359

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Fix null dereference in spa_vdev_remove_cancel_sync()
908bfb0 
We don't really need to access space map to know where the metaslab
ends, while msp->ms_sm might be NULL.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Fixes openzfs#17164
Fixes openzfs#17359
@amotin amotin mentioned this pull request May 21, 2025
Closed
@amotin amotin added the Status: Code Review Needed Ready for review and testing label May 21, 2025
behlendorf
behlendorf approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 21, 2025
@amotin amotin merged commit 5c30b24 into openzfs:master May 22, 2025
23 of 24 checks passed
@amotin amotin deleted the remove_null branch May 22, 2025 14:47
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@amotin @robn
Fix null dereference in spa_vdev_remove_cancel_sync()
a332ba2 
We don't really need to access space map to know where the metaslab
ends, while msp->ms_sm might be NULL.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Fixes openzfs#17164
Fixes openzfs#17359
Closes openzfs#17361
(cherry picked from commit 5c30b24)
@robn robn mentioned this pull request May 23, 2025
Closed
14 tasks
robn pushed a commit to robn/zfs that referenced this pull request May 24, 2025
@amotin @robn
Fix null dereference in spa_vdev_remove_cancel_sync()
4321bf5 
We don't really need to access space map to know where the metaslab
ends, while msp->ms_sm might be NULL.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Fixes openzfs#17164
Fixes openzfs#17359
Closes openzfs#17361
(cherry picked from commit 5c30b24)
tonyhutter pushed a commit that referenced this pull request May 28, 2025
@amotin @tonyhutter
Fix null dereference in spa_vdev_remove_cancel_sync()
64e77fd 
We don't really need to access space map to know where the metaslab
ends, while msp->ms_sm might be NULL.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Fixes #17164
Fixes #17359
Closes #17361
(cherry picked from commit 5c30b24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robn robn robn approved these changes

@behlendorf behlendorf behlendorf approved these changes

@ikozhukhov ikozhukhov ikozhukhov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in spa_vdev_remove_cancel_sync() on metaslab with empty spacemap
4 participants
@amotin @robn @behlendorf @ikozhukhov