ZTS: Fix replacement/resilver_restart_001 on FreeBSD #17279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmelikov
approved these changes
Apr 27, 2025
|
I wonder if it is actually the same problem as I see in #17269 -- "online" (re-)starts resilver asynchronously. |
Yes, they seem to be related. But I didn't go into the details for this fix. Increasing the size just resolved the |
|
@mcmilk I agree with @snajpa that it makes no logical sense to me. I don't have a particular problem with increasing the write size to 32MB, but I worry that the problem might re-appear later when we change something in CI or OS. I think some |
Decrease the RESILVER_MIN_TIME_MS variable from 50 to 20. So the test, which expects two 2 resilver starts will see them. Logfile of the seen failures before this fix: log: NOTE: expected 2 resilver start(s) after offline/online, found 1 log: expected 2 resilver start(s) after offline/online, found 1 The test time decreases also from around 00:42 to 00:24 seconds. Signed-off-by: Tino Reichardt <[email protected]> Closes: openzfs#16822
mcmilk
force-pushed
the
fix-resilver_restart_001
branch
from
69139c8 to
4e2a990
Compare
tonyhutter
approved these changes
May 1, 2025
amotin
approved these changes
May 1, 2025
robn
pushed a commit
to robn/zfs
that referenced
this pull request
May 23, 2025
Decrease the RESILVER_MIN_TIME_MS variable from 50 to 20. So the test, which expects two 2 resilver starts will see them. Logfile of the seen failures before this fix: log: NOTE: expected 2 resilver start(s) after offline/online, found 1 log: expected 2 resilver start(s) after offline/online, found 1 The test time decreases also from around 00:42 to 00:24 seconds. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16822 Closes openzfs#17279 (cherry picked from commit 3b18877)
robn
pushed a commit
to robn/zfs
that referenced
this pull request
May 24, 2025
Decrease the RESILVER_MIN_TIME_MS variable from 50 to 20. So the test, which expects two 2 resilver starts will see them. Logfile of the seen failures before this fix: log: NOTE: expected 2 resilver start(s) after offline/online, found 1 log: expected 2 resilver start(s) after offline/online, found 1 The test time decreases also from around 00:42 to 00:24 seconds. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16822 Closes openzfs#17279 (cherry picked from commit 3b18877)
tonyhutter
pushed a commit
that referenced
this pull request
May 28, 2025
Decrease the RESILVER_MIN_TIME_MS variable from 50 to 20. So the test, which expects two 2 resilver starts will see them. Logfile of the seen failures before this fix: log: NOTE: expected 2 resilver start(s) after offline/online, found 1 log: expected 2 resilver start(s) after offline/online, found 1 The test time decreases also from around 00:42 to 00:24 seconds. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes #16822 Closes #17279 (cherry picked from commit 3b18877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Details on the issue can be seen here #16822
Increasing the data files from 16M to 32M fixes the replacement/resilver_restart_001 test.
Closes: #16822
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.