Skip to content

ZTS: Polish online_offline tests #17259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

ZTS: Polish online_offline tests #17259

merged 1 commit into from
Apr 23, 2025

Conversation

amotin
Copy link
Member

@amotin amotin commented Apr 22, 2025

  • Kill workload first for faster cleanup.
  • Use zpool wait for resilver instead of sleep.
  • Remove irrelevant workload from online_offline_003_neg.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin changed the title ZFS: Polish online_offline tests ZTS: Polish online_offline tests Apr 22, 2025
@amotin
ZTS: Polish online_offline tests
3bdb928 
 - Kill workload first for faster cleanup.
 - Use `zpool wait` for resilver instead of `sleep`.
 - Remove irrelevant workload from `online_offline_003_neg`.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 22, 2025
@amotin amotin merged commit cb49e77 into openzfs:master Apr 23, 2025
21 of 24 checks passed
@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 23, 2025
@amotin amotin deleted the online_offline branch April 23, 2025 01:04
@amotin amotin mentioned this pull request Apr 24, 2025
Closed
13 tasks
amotin added a commit to amotin/zfs that referenced this pull request Apr 25, 2025
@amotin
ZTS: Restore some delays in online_offline tests
389dde6 
After more CI runs and code reading after openzfs#17259 I've found that
online starts resilver via async mechanism, which does not provide
wait primitives at this time.  Restore some delays to restore CI
until this is properly fixed.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request May 2, 2025
@amotin @snajpa
ZTS: Polish online_offline tests
03203da 
 - Kill workload first for faster cleanup.
 - Use `zpool wait` for resilver instead of `sleep`.
 - Remove irrelevant workload from `online_offline_003_neg`.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes: openzfs#17259
tonyhutter pushed a commit that referenced this pull request May 2, 2025
@amotin @tonyhutter
ZTS: Restore some delays in online_offline tests
f85c96e 
After more CI runs and code reading after #17259 I've found that
online starts resilver via async mechanism, which does not provide
wait primitives at this time.  Restore some delays to restore CI
until this is properly fixed.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@amotin @robn
ZTS: Polish online_offline tests
b2214f1 
 - Kill workload first for faster cleanup.
 - Use `zpool wait` for resilver instead of `sleep`.
 - Remove irrelevant workload from `online_offline_003_neg`.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes: openzfs#17259
(cherry picked from commit cb49e77)
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@amotin @robn
ZTS: Restore some delays in online_offline tests
659bc19 
After more CI runs and code reading after openzfs#17259 I've found that
online starts resilver via async mechanism, which does not provide
wait primitives at this time.  Restore some delays to restore CI
until this is properly fixed.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
(cherry picked from commit f85c96e)
@robn robn mentioned this pull request May 23, 2025
Closed
14 tasks
robn pushed a commit to robn/zfs that referenced this pull request May 24, 2025
@amotin @robn
ZTS: Polish online_offline tests
ccc92e2 
 - Kill workload first for faster cleanup.
 - Use `zpool wait` for resilver instead of `sleep`.
 - Remove irrelevant workload from `online_offline_003_neg`.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes: openzfs#17259
(cherry picked from commit cb49e77)
robn pushed a commit to robn/zfs that referenced this pull request May 24, 2025
@amotin @robn
ZTS: Restore some delays in online_offline tests
bc32e41 
After more CI runs and code reading after openzfs#17259 I've found that
online starts resilver via async mechanism, which does not provide
wait primitives at this time.  Restore some delays to restore CI
until this is properly fixed.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
(cherry picked from commit f85c96e)
tonyhutter pushed a commit that referenced this pull request May 28, 2025
@amotin @tonyhutter
ZTS: Polish online_offline tests
03ac770 
 - Kill workload first for faster cleanup.
 - Use `zpool wait` for resilver instead of `sleep`.
 - Remove irrelevant workload from `online_offline_003_neg`.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes: #17259
(cherry picked from commit cb49e77)
tonyhutter pushed a commit that referenced this pull request May 28, 2025
@amotin @tonyhutter
ZTS: Restore some delays in online_offline tests
52749eb 
After more CI runs and code reading after #17259 I've found that
online starts resilver via async mechanism, which does not provide
wait primitives at this time.  Restore some delays to restore CI
until this is properly fixed.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
(cherry picked from commit f85c96e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @gmelikov @tonyhutter