config: fix ZFS_LINUX_TEST_RESULT_SYMBOL with --enable-linux-builtin #17236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tiniest typo in dd2a46b (openzfs#17106) broke it, by setting the wrong var with the test var, resulting in it always producing "no". Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>
amotin
approved these changes
Apr 11, 2025
AttilaFueloep
approved these changes
Apr 11, 2025
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 15, 2025
The tiniest typo in dd2a46b (openzfs#17106) broke it, by setting the wrong var with the test var, resulting in it always producing "no". Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Alexander Motin <[email protected]> Reviewed by: Attila Fülöp <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes openzfs#17236
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 16, 2025
The tiniest typo in dd2a46b (openzfs#17106) broke it, by setting the wrong var with the test var, resulting in it always producing "no". Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Alexander Motin <[email protected]> Reviewed by: Attila Fülöp <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes openzfs#17236
snajpa
pushed a commit
to vpsfreecz/zfs
that referenced
this pull request
May 2, 2025
The tiniest typo in dd2a46b (openzfs#17106) broke it, by setting the wrong var with the test var, resulting in it always producing "no". Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Alexander Motin <[email protected]> Reviewed by: Attila Fülöp <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes openzfs#17236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#17106 broke compiling with
--enable-linux-builtin.Fixes #17212.
Description
A typo in
ZFS_LINUX_TEST_RESULT_SYMBOLmade it always return "no" when setting up for an in-kernel build, so configure ended up failing in.Just fix the typo, oosh.
How Has This Been Tested?
Tested locally with all combinations of
--enable-linux-builtinand--config-cache.#17212 reports success also.
Types of changes
Checklist:
Signed-off-by.