Skip to content

dmu_tx: rename dmu_tx_assign() flags from TXG_* to DMU_TX_* #17143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

robn
Copy link
Member

@robn robn commented Mar 13, 2025

[Sponsors: Klara, Inc., Wasabi Technology, Inc.]

Motivation and Context

On its own, helps to avoid confusion with the similarly-named txg_wait_synced().

But actually, at Klara there's a couple of active development projects (at least forced export (#11082), some more work around fsync()) that will want to extend txg_wait_synced() to also have flags describing the conditions it may exit. For these, we've settled on TXG_WAIT_* as the obvious name for such flags, and we want to reclaim that namespace.

Description

Mechanical replacement of TXG_* with DMU_TX_*.

How Has This Been Tested?

This version compile-checked only, though it is in heavy use in our internal projects as well.

Since it's just renaming three (+1 in ztest) numeric defines, I don't expect anything of interest.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This helps to avoids confusion with the similarly-named
txg_wait_synced().

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish it was not so invasive...

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Mar 13, 2025
@robn
Copy link
Member Author

robn commented Mar 14, 2025

Yeah, bit noisy but at least we only have to do it once.

@oshogbo
Copy link
Contributor

oshogbo commented Mar 14, 2025

LGTM.

@amotin
Copy link
Member

amotin commented Mar 14, 2025

@oshogbo There is "Review changes" button on the "Files changed" tab. ;)

@tonyhutter tonyhutter merged commit f696319 into openzfs:master Mar 18, 2025
35 of 41 checks passed
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 3, 2025
…17143)

This helps to avoids confusion with the similarly-named
txg_wait_synced().

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Mariusz Zaborski <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
…17143)

This helps to avoids confusion with the similarly-named
txg_wait_synced().

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Mariusz Zaborski <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
…17143)

This helps to avoids confusion with the similarly-named
txg_wait_synced().

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Mariusz Zaborski <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2025
…17143)

This helps to avoids confusion with the similarly-named
txg_wait_synced().

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Mariusz Zaborski <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants