-
Notifications
You must be signed in to change notification settings - Fork 1.8k
dmu_tx: rename dmu_tx_assign()
flags from TXG_*
to DMU_TX_*
#17143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to avoids confusion with the similarly-named txg_wait_synced(). Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
amotin
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wish it was not so invasive...
Yeah, bit noisy but at least we only have to do it once. |
LGTM. |
@oshogbo There is "Review changes" button on the "Files changed" tab. ;) |
oshogbo
approved these changes
Mar 17, 2025
tonyhutter
approved these changes
Mar 18, 2025
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 3, 2025
…17143) This helps to avoids confusion with the similarly-named txg_wait_synced(). Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Mariusz Zaborski <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
fuporovvStack
pushed a commit
to fuporovvStack/zfs
that referenced
this pull request
Apr 11, 2025
…17143) This helps to avoids confusion with the similarly-named txg_wait_synced(). Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Mariusz Zaborski <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
fuporovvStack
pushed a commit
to fuporovvStack/zfs
that referenced
this pull request
Apr 11, 2025
…17143) This helps to avoids confusion with the similarly-named txg_wait_synced(). Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Mariusz Zaborski <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 16, 2025
…17143) This helps to avoids confusion with the similarly-named txg_wait_synced(). Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Mariusz Zaborski <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
On its own, helps to avoid confusion with the similarly-named
txg_wait_synced()
.But actually, at Klara there's a couple of active development projects (at least forced export (#11082), some more work around
fsync()
) that will want to extendtxg_wait_synced()
to also have flags describing the conditions it may exit. For these, we've settled onTXG_WAIT_*
as the obvious name for such flags, and we want to reclaim that namespace.Description
Mechanical replacement of
TXG_*
withDMU_TX_*
.How Has This Been Tested?
This version compile-checked only, though it is in heavy use in our internal projects as well.
Since it's just renaming three (+1 in ztest) numeric defines, I don't expect anything of interest.
Types of changes
Checklist:
Signed-off-by
.