Skip to content

Fix few __VA_ARGS typos in assertions #16780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix few __VA_ARGS typos in assertions #16780

merged 1 commit into from
Nov 19, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Nov 18, 2024 •
edited
Loading

It should be __VA_ARGS__, not __VA_ARGS.

How Has This Been Tested?

Used one of those macros and observed failed build, which this change fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Fix few __VA_ARGS typos in assertions
b9c9e0e 
It should be __VA_ARGS__, not __VA_ARGS.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 19, 2024
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 19, 2024
@behlendorf behlendorf merged commit 0d6306b into openzfs:master Nov 19, 2024
20 of 24 checks passed
@amotin amotin deleted the vaargs branch November 19, 2024 15:01
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 21, 2024
@amotin @behlendorf
Fix few __VA_ARGS typos in assertions
09c7c6c 
It should be __VA_ARGS__, not __VA_ARGS.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16780
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 21, 2024
@amotin @behlendorf
Fix few __VA_ARGS typos in assertions
8023d9d 
It should be __VA_ARGS__, not __VA_ARGS.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16780
ixhamza pushed a commit to truenas/zfs that referenced this pull request Dec 2, 2024
@amotin @ixhamza
Fix few __VA_ARGS typos in assertions
ea28cd1 
It should be __VA_ARGS__, not __VA_ARGS.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16780
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
@amotin @lundman
Fix few __VA_ARGS typos in assertions
9a62bd3 
It should be __VA_ARGS__, not __VA_ARGS.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robn robn robn approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @robn @behlendorf