Packaging: Auto-generate changelog during configure #15528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-generate changelog based off on @Version@ during configure, so that it is not needed to be update with new releases / version updates. Signed-off-by: Umer Saleem <[email protected]>
tonyhutter
reviewed
Nov 15, 2023
|
|
||
| * OpenZFS @VERSION@ is tagged. | ||
|
|
||
| -- Umer Saleem <[email protected]> Wed, 15 Nov 2023 15:00:00 +0500 |
There was a problem hiding this comment.
I assume it's ok to leave the date as a static Wed, 15 Nov 2023 15:00:00 +0500 here right?
There was a problem hiding this comment.
Yes, I think should be. Ideally this should be the date of the release, but since we are not doing that, and the other option is to insert the current time stamp (at the time configure runs), which is not correct either, I think setting to a prior date should be alright.
tonyhutter
approved these changes
Nov 16, 2023
tonyhutter
approved these changes
Nov 16, 2023
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Nov 20, 2023
Auto-generate changelog based off on @Version@ during configure, so that it is not needed to be update with new releases / version updates. Signed-off-by: Umer Saleem <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Auto-generate changelog based off on @Version@ during configure, so that it is not needed to be update with new releases / version updates. Signed-off-by: Umer Saleem <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With new releases and version updates,
contrib/debian/changelogneeds to be updated with a new changelog entry, this adds an extra step for release process.Description
Auto-generate changelog based off on
@VERSION@during configure, so that it is not needed to be update with new releases / version updates.How Has This Been Tested?
Created native Debian packages after the update. Confirmed they are generated with same version, as before (2.2.99 for master branch).
Types of changes
Checklist:
Signed-off-by.