Skip to content

Fix use-after-free in btree code #13861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix use-after-free in btree code #13861

merged 1 commit into from
Sep 12, 2022

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Sep 9, 2022 •
edited
Loading

Motivation and Context

Coverty found two use-after-free bugs in btree.c.

Description

Moved zfs_btree_node_destroy() after zfs_btree_remove_from_node().

How Has This Been Tested?

No local testing has been done. Buildbot testing is expected to be sufficient.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ryao
Fix use-after-free in btree code
a6f2e6f 
Coverty static analysis found these.

Signed-off-by: Richard Yao <[email protected]>
@ryao ryao mentioned this pull request Sep 11, 2022
Closed
@ryao
Copy link
Contributor Author

ryao commented Sep 12, 2022

I am now >99% certain that this fixes #10989.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 12, 2022
@behlendorf behlendorf merged commit 13f2b8f into openzfs:master Sep 12, 2022
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 13, 2022
@ryao @tonyhutter
Fix use-after-free in btree code
8131a96 
Coverty static analysis found these.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#10989
Closes openzfs#13861
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@ryao @beren12
Fix use-after-free in btree code
02bd89a 
Coverty static analysis found these.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#10989
Closes openzfs#13861
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 22, 2022
@ryao @snajpa
Fix use-after-free in btree code
bdf7a7e 
Coverty static analysis found these.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#10989
Closes openzfs#13861
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 22, 2022
@ryao @snajpa
Fix use-after-free in btree code
cfb6524 
Coverty static analysis found these.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#10989
Closes openzfs#13861
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 23, 2022
@ryao @snajpa
Fix use-after-free in btree code
dd54a69 
Coverty static analysis found these.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#10989
Closes openzfs#13861
geoffamey pushed a commit to BlueArchive/storage-zfs-wasabi that referenced this pull request Jul 5, 2023
@ryao @geoffamey
Fix use-after-free in btree code
18ae267 
Coverty static analysis found these.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#10989
Closes openzfs#13861
(cherry picked from commit 13f2b8f)
@ryao ryao mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@amotin amotin amotin approved these changes

@pcd1193182 pcd1193182 Awaiting requested review from pcd1193182

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryao @behlendorf @Conan-Kudo @amotin