Skip to content

abd_os: remove redundant refcount creation for abd_children #13429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

abd_os: remove redundant refcount creation for abd_children #13429

merged 1 commit into from
May 9, 2022

Conversation

hpingfs
Copy link
Contributor

@hpingfs hpingfs commented May 6, 2022

Motivation and Context

Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

How Has This Been Tested?

Without this patch, libzpool build fails with ZFS_DEBUG disabled.
With this patch, the build succeeds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly. - none apply
  • I have read the contributing document.
  • I have added tests to cover my changes. - none apply
  • I have run the ZFS Test Suite with this change applied. - CI takes my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@hpingfs
abd_os: remove redundant refcount creation for abd_children
4488402 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Signed-off-by: Ping Huang <[email protected]>
@hpingfs hpingfs mentioned this pull request May 6, 2022
Closed
13 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 6, 2022
@behlendorf behlendorf merged commit a18d13c into openzfs:master May 9, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 17, 2022
@hpingfs @behlendorf
abd_os: remove redundant refcount creation for abd_children
216e309 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
behlendorf pushed a commit that referenced this pull request May 20, 2022
@hpingfs @behlendorf
abd_os: remove redundant refcount creation for abd_children
b28c0c4 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes #13429
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@hpingfs @nicman23
abd_os: remove redundant refcount creation for abd_children
fbb666d 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@hpingfs @nicman23
abd_os: remove redundant refcount creation for abd_children
15aa1c7 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
@hpingfs hpingfs deleted the fix-redundant-refcnt branch August 25, 2022 08:17
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 6, 2022
@hpingfs @lundman
abd_os: remove redundant refcount creation for abd_children
64a8df0 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@hpingfs @beren12
abd_os: remove redundant refcount creation for abd_children
85f60df 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
d53c07b 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
bbafcfa 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
92cf5fc 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
ffcb0dd 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
ea2a6e3 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
d7b9f7d 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
f7f8881 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
2b2d43d 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
1cbb12b 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
e127ef3 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
6f103f7 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
d368494 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
728ce28 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
95f9f5f 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
927b0c0 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
7a49fd4 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
123a240 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
789c98c 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@hpingfs @andrewc12
abd_os: remove redundant refcount creation for abd_children
4d48099 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 22, 2022
@hpingfs @snajpa
abd_os: remove redundant refcount creation for abd_children
e6a6987 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 22, 2022
@hpingfs @snajpa
abd_os: remove redundant refcount creation for abd_children
dba8a4e 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 23, 2022
@hpingfs @snajpa
abd_os: remove redundant refcount creation for abd_children
5e64587 
Refcount creation for abd_zero_scatter->abd_children is redundant in
abd_alloc_zero_scatter, as it has been done in abd_init_struct.

In addition, abd_children is undefined when ZFS_DEBUG is disabled, the
reference of abd_children in abd_alloc_zero_scatter breaks build of
libzpool when ZFS_DEBUG is disabled.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Ping Huang <[email protected]>
Closes openzfs#13429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@bwatkinson bwatkinson bwatkinson approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpingfs @behlendorf @bwatkinson