Skip to content

ZTS: Fix refreserv_raidz.ksh #12897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2021
Merged

ZTS: Fix refreserv_raidz.ksh #12897

merged 1 commit into from
Dec 22, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #12848. Plus it's a long standing test failure which needed
to be investigated and resolved. As expected, it was caused by a
flaw in the test case.

Description

The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee pool sync. Switch to using the sync_pool
function and remove the ZTS exception for Linux.

How Has This Been Tested?

The test case would reliably fail on Linux prior to this change. After the
change it passes reliably.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
ZTS: Fix refreserv_raidz.ksh
5f576f3 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Dec 21, 2021
allanjude
allanjude approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@allanjude allanjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Allan Jude [email protected]

@behlendorf behlendorf requested review from a user and jwk404 December 22, 2021 00:34
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 22, 2021
@behlendorf behlendorf merged commit 9ba5d8d into openzfs:master Dec 22, 2021
@behlendorf behlendorf mentioned this pull request Dec 22, 2021
Closed
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@behlendorf @tonyhutter
ZTS: Fix refreserv_raidz.ksh
9dc2a10 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12897
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 14, 2022
@behlendorf @tonyhutter
ZTS: Fix refreserv_raidz.ksh
38eecc1 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12897
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@behlendorf @tonyhutter
ZTS: Fix refreserv_raidz.ksh
71b9d4b 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12897
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@behlendorf @tonyhutter
ZTS: Fix refreserv_raidz.ksh
74bba85 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12897
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
ZTS: Fix refreserv_raidz.ksh
d17fb9c 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12897
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
ZTS: Fix refreserv_raidz.ksh
232fbb0 
The rerefreserv_raidz test was failing on Linux because the sync being
issued doesn't guarantee a pool sync.  Switch to using the sync_pool
function and remove the ZTS exception for Linux.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwk404 jwk404 jwk404 approved these changes

@allanjude allanjude allanjude approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@behlendorf @jwk404 @allanjude @gmelikov