Skip to content

config/libatomic: require -latomic iff atomic.c doesn't link without it #12359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

config/libatomic: require -latomic iff atomic.c doesn't link without it #12359

merged 1 commit into from
Jul 13, 2021

Conversation

nabijaczleweli
Copy link
Contributor

Motivation and Context

#12345

Description

See commit message.

How Has This Been Tested?

Requires -latomic on amd64 with a forced unresolved symbol, doesn't on plain amd64.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – as above
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
5e68803 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12345
@nabijaczleweli nabijaczleweli mentioned this pull request Jul 13, 2021
Closed
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 13, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 13, 2021
@behlendorf behlendorf self-assigned this Jul 13, 2021
@behlendorf behlendorf merged commit d9f0f15 into openzfs:master Jul 13, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@nabijaczleweli @behlendorf
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
38f4c5e 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12345 
Closes openzfs#12359
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@nabijaczleweli @behlendorf
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
f7d30c0 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12345 
Closes openzfs#12359
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@nabijaczleweli
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
30c0fce 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12345 
Closes openzfs#12359
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@nabijaczleweli @behlendorf
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
d06bd2f 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12345
Closes openzfs#12359
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@nabijaczleweli @behlendorf
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
43849d6 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12345
Closes #12359
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@nabijaczleweli @tonyhutter
config/libatomic: require -latomic iff atomic.c doesn't link w/o it
968dc13 
In absence of LTO, and dynamic libatomic, la.so ends up in the needs
section of every toolchain executable; some consider this an issue.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12345
Closes openzfs#12359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@behlendorf behlendorf

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabijaczleweli @behlendorf