Skip to content

zfs_metaslab_mem_limit should be 25 instead of 75 #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

jumbi77
Copy link
Contributor

@jumbi77 jumbi77 commented Jun 23, 2021

Motivation and Context

Description

According to current zfs man page zfs_metaslab_mem_limit should be 25 instead of 75

Follow up of PR #12258

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

According to current zfs man page zfs_metaslab_mem_limit should be 25 instead of 75

Signed-off-by: [email protected]
@ahrens ahrens requested a review from pcd1193182 June 23, 2021 21:04
@mmaybee
Copy link
Contributor

mmaybee commented Jun 23, 2021

@jumbi77 Could you rewrite your commit message so that each line is < 72 characters? You could probably just use:
"zfs_metaslab_mem_limit should be 25 instead of 75"

@mmaybee mmaybee added the Status: Accepted Ready to integrate (reviewed, tested) label Jun 23, 2021
@behlendorf behlendorf merged commit 86f5e0b into openzfs:master Jun 24, 2021
@behlendorf
Copy link
Contributor

@jumbi77 we went ahead and updated the commit message when merging this to keep the line length under 72 characters. Thanks for catching this issue and opening a PR for it.

behlendorf pushed a commit that referenced this pull request Jun 24, 2021
According to current zfs man page zfs_metaslab_mem_limit should be
25 instead of 75.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Mark Maybee <[email protected]>
Signed-off-by: [email protected]
Closes #12273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants