Skip to content

i-t: let rootdelay= set $ZFS_INITRD_PRE_MOUNTROOT_SLEEP #12148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

i-t: let rootdelay= set $ZFS_INITRD_PRE_MOUNTROOT_SLEEP #12148

wants to merge 2 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

Motivation and Context

#11663, #11420 (comment)

Description

It's what it says on the tin

How Has This Been Tested?

It boots as expected

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – likewise
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli nabijaczleweli mentioned this pull request May 28, 2021
Closed
@nabijaczleweli
i-t: don't suggest zpool-import with altroot to /root
c78498b 
This *will fail* when remounted by the real root

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
behlendorf
behlendorf approved these changes May 30, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, and I see it was independently verified in #11420. Thanks.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 30, 2021
behlendorf pushed a commit that referenced this pull request May 30, 2021
@nabijaczleweli @behlendorf
i-t: don't suggest zpool-import with altroot to /root
8d5f211 
This *will fail* when remounted by the real root

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12148
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 3, 2021
@nabijaczleweli @behlendorf
i-t: let rootdelay= set $ZFS_INITRD_PRE_MOUNTROOT_SLEEP
23e6ec0 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Ref: openzfs#11420 (comment)
Closes openzfs#11663
Closes openzfs#12148
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 3, 2021
@nabijaczleweli @behlendorf
i-t: don't suggest zpool-import with altroot to /root
a5b0773 
This *will fail* when remounted by the real root

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12148
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
i-t: let rootdelay= set $ZFS_INITRD_PRE_MOUNTROOT_SLEEP
edc5747 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Ref: openzfs#11420 (comment)
Closes openzfs#11663
Closes openzfs#12148
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
i-t: don't suggest zpool-import with altroot to /root
3cd7cd4 
This *will fail* when remounted by the real root

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12148
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 9, 2021
@nabijaczleweli @behlendorf
i-t: let rootdelay= set $ZFS_INITRD_PRE_MOUNTROOT_SLEEP
90d0023 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Ref: openzfs#11420 (comment)
Closes openzfs#11663
Closes openzfs#12148
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 9, 2021
@nabijaczleweli @behlendorf
i-t: don't suggest zpool-import with altroot to /root
2f5c391 
This *will fail* when remounted by the real root

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabijaczleweli @behlendorf