zfs.spec.in: remove post ldconfig scriptlets #11931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
Component: Packaging
ofaaland
suggested changes
Apr 26, 2021
behlendorf
force-pushed
the
ldconfig-scriptlets
branch
from
3cdbf9c to
374c5cc
Compare
In Fedora 28 the packaging guidelines were changed such that ldconfig should no longer be called in either the %post or %postun scriptlets. Instead the new compatibility macros %ldconfig_post, %ldconfig_postun, and %ldocnfig_scriptlets should be used. Since we only currently support Fedora 31 and newer, we could drop %post or %postun scriptlets entirely according to the guidelines. However, since we also use the same spec file for CentOS / RHEL it's convenient to call the macros which are available starting with CentOS / RHEL 8. For CentOS / RHEL 7 we must still call ldconfig in the traditional way. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf
force-pushed
the
ldconfig-scriptlets
branch
from
374c5cc to
8b0b591
Compare
tonyhutter
approved these changes
Apr 27, 2021
behlendorf
added
Status: Accepted
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
May 10, 2021
In Fedora 28 the packaging guidelines were changed such that ldconfig should no longer be called in either the %post or %postun scriptlets. Instead the new compatibility macros %ldconfig_post, %ldconfig_postun, and %ldocnfig_scriptlets should be used. Since we only currently support Fedora 31 and newer, we could drop %post or %postun scriptlets entirely according to the guidelines. However, since we also use the same spec file for CentOS / RHEL it's convenient to call the macros which are available starting with CentOS / RHEL 8. For CentOS / RHEL 7 we must still call ldconfig in the traditional way. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets Reviewed-by: Olaf Faaland <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#11931
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
In Fedora 28 the packaging guidelines were changed such that ldconfig should no longer be called in either the %post or %postun scriptlets. Instead the new compatibility macros %ldconfig_post, %ldconfig_postun, and %ldocnfig_scriptlets should be used. Since we only currently support Fedora 31 and newer, we could drop %post or %postun scriptlets entirely according to the guidelines. However, since we also use the same spec file for CentOS / RHEL it's convenient to call the macros which are available starting with CentOS / RHEL 8. For CentOS / RHEL 7 we must still call ldconfig in the traditional way. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets Reviewed-by: Olaf Faaland <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#11931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When installing packages on Fedora 33 the following warning is printed:
The packages should install cleanly without any warnings.
Description
In Fedora 28 the packaging guidelines were changed such that
ldconfigshould no longer be called in either the
%post or%postunscriptlets.Instead the new compatibility macros
%ldconfig_post,%ldconfig_postun,and
%ldocnfig_scriptletsshould be used.Since we only support Fedora 31 and newer, we could drop the
%postand%postunscriptlets entirely according to the guidelines.However, since we also use the same spec file for CentOS / RHEL
it's convenient to call the macros which are available starting
with CentOS / RHEL 8. For CentOS / RHEL 7 we must still call
ldconfigin the traditional way.https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
How Has This Been Tested?
Verified the packages install cleanly and work on Fedora 33.
Verified the required macros are installed on CentOS / RHEL 8.
No functional change for CentOS / RHEL 7.
Pending additional confirmation from the CI which builds and installs
packages for all of these platforms.
Types of changes
Checklist:
Signed-off-by.