Skip to content

Add compatibility file sets for ZFSonLinux 0.6.1 and 0.6.4 #11818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

chungy
Copy link
Contributor

@chungy chungy commented Mar 30, 2021

Motivation and Context

For completion's sake, there were a couple versions of ZFSonLinux below 0.6.5 that may, in some way, be relevant when building pools compatible with old versions.

Description

Added two files for the feature sets of 0.6.1 and 0.6.4.

How Has This Been Tested?

Have not tested it (have not built 2.1 yet), but the file format is simple enough to grasp.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

ZoL 0.6.1 introduced feature flags with the three features that all
implementations at the time were guaranteed to have.  0.6.4 introduced
a few more until 0.6.5 added two after that.

Signed-off-by: Mike Swanson <[email protected]>
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There listed features here look right so this should work. Would you mind also adding openzfs-2.1-linux and openzfs-2.1-freebsd to this PR now that it has branched. The only new feature flag is draid.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Mar 30, 2021
@chungy
Copy link
Contributor Author

chungy commented Mar 30, 2021

I've pushed the OpenZFS 2.1 files too

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 31, 2021
@behlendorf behlendorf merged commit 67859ae into openzfs:master Mar 31, 2021
@chungy chungy deleted the compatibility_sets branch April 1, 2021 00:11
behlendorf pushed a commit that referenced this pull request Apr 7, 2021
ZoL 0.6.1 introduced feature flags with the three features that all
implementations at the time were guaranteed to have.  0.6.4 introduced
a few more until 0.6.5 added two after that.  OpenZFS 2.1 added the
dRAID feature.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Mike Swanson <[email protected]>
Closes #11818
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
ZoL 0.6.1 introduced feature flags with the three features that all
implementations at the time were guaranteed to have.  0.6.4 introduced
a few more until 0.6.5 added two after that.  OpenZFS 2.1 added the
dRAID feature.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Mike Swanson <[email protected]>
Closes openzfs#11818
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
ZoL 0.6.1 introduced feature flags with the three features that all
implementations at the time were guaranteed to have.  0.6.4 introduced
a few more until 0.6.5 added two after that.  OpenZFS 2.1 added the
dRAID feature.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Mike Swanson <[email protected]>
Closes openzfs#11818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants