Add SIGSTOP and SIGTSTP handling to issig #11801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrens
reviewed
Mar 25, 2021
behlendorf
reviewed
Mar 30, 2021
behlendorf
reviewed
Apr 6, 2021
behlendorf
reviewed
Apr 8, 2021
ahrens
reviewed
Apr 10, 2021
ahrens
approved these changes
Apr 10, 2021
behlendorf
reviewed
Apr 11, 2021
pcd1193182
force-pushed
the
signals
branch
2 times, most recently
from
c1b5772 to
63f2095
Compare
behlendorf
approved these changes
Apr 12, 2021
Signed-off-by: Paul Dagnelie <[email protected]>
pcd1193182
force-pushed
the
signals
branch
2 times, most recently
from
9d03d9a to
919f2fa
Compare
Signed-off-by: Paul Dagnelie <[email protected]>
behlendorf
reviewed
Apr 14, 2021
behlendorf
added
Status: Accepted
Signed-off-by: Paul Dagnelie <[email protected]>
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Apr 21, 2021
This change adds SIGSTOP and SIGTSTP handling to the issig function; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Issue openzfs#810 Issue openzfs#10843 Closes openzfs#11801
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
This change adds SIGSTOP and SIGTSTP handling to the issig function; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Issue openzfs#810 Issue openzfs#10843 Closes openzfs#11801
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 7, 2021
This change adds SIGSTOP and SIGTSTP handling to the issig function; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Issue openzfs#810 Issue openzfs#10843 Closes openzfs#11801
tonyhutter
pushed a commit
that referenced
this pull request
Sep 21, 2021
This change adds SIGSTOP and SIGTSTP handling to the issig function; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Issue #810 Issue #10843 Closes #11801
tonyhutter
pushed a commit
that referenced
this pull request
Sep 22, 2021
This change adds SIGSTOP and SIGTSTP handling to the issig function; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Issue #810 Issue #10843 Closes #11801
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 7, 2021
This change adds SIGSTOP and SIGTSTP handling to the issig function; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Issue openzfs#810 Issue openzfs#10843 Closes openzfs#11801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, ZFS send and receive die if you send them SIGSTOP or SIGTSTP. This was originally raised in #810, and was supposedly fixed in #10843, but that fix doesn't appear to contain any relevant logic to this issue.
Description
This change adds SIGSTOP and SIGTSTP handling to the
issigfunction; this mirrors its behavior on Solaris. This way, long running kernel tasks can be stopped with the appropriate signals. Note that doing so with ctrl-z on the command line doesn't return control of the tty to the shell, because tty handling is done separately from stopping the process. That can be future work, if people feel that it is a necessary addition.Note that this problem also exists on FreeBSD (I believe; haven't tested manually) and this PR does not address that.
How Has This Been Tested?
ZFS test suite passed, changes loaded onto a VM and SIGSTOP sent to running sends/receives. Verified that the processes stopped when the signals were received, and then resumed when sent SIGCONT.
Types of changes
Checklist:
Signed-off-by.