Fix typos #11774
Closed
Fix typos #11774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Gelmini <[email protected]>
ahrens
reviewed
Mar 21, 2021
| @@ -1008,7 +1008,7 @@ avl_destroy_nodes(avl_tree_t *tree, void **cookie) | |||
| --tree->avl_numnodes; | |||
|
|
|||
| /* | |||
| * If we just did a right child or there isn't one, go up to parent. | |||
| * If we just made a right child or there isn't one, go up to parent. | |||
There was a problem hiding this comment.
I don't think we are "making" any nodes here; "did" seems ok to me, or we could change it to "removed"
| @@ -21273,7 +21273,7 @@ ZSTD_initStats_ultra(ZSTD_matchState_t* ms, | |||
| ms->window.lowLimit = ms->window.dictLimit; | |||
| ms->nextToUpdate = ms->window.dictLimit; | |||
|
|
|||
| /* re-inforce weight of collected statistics */ | |||
| /* re-enforce weight of collected statistics */ | |||
There was a problem hiding this comment.
this one isn't clear to me which way it should be... are we "enforcing" some sort of rule? or are we "reinforcing" (supplementing, increasing) the weight? Maybe better to chose a different word altogether.
There was a problem hiding this comment.
We should prefer making any changes to zstd.c and zstd.h through upstream.
| @@ -44,7 +44,7 @@ function cleanup | |||
| rm -f ${VDEV_FILES[@]} | |||
| } | |||
|
|
|||
| log_assert "Verify attach/detech with multiple vdevs" | |||
| log_assert "Verify attach/detect with multiple vdevs" | |||
There was a problem hiding this comment.
Suggested change
| log_assert "Verify attach/detect with multiple vdevs" | |
| log_assert "Verify attach/detach with multiple vdevs" |
| @@ -108,4 +108,4 @@ for replace_mode in "healing" "sequential"; do | |||
| log_must zpool wait $TESTPOOL1 | |||
| done | |||
|
|
|||
| log_pass "Verify attach/detech with multiple vdevs" | |||
| log_pass "Verify attach/detect with multiple vdevs" | |||
There was a problem hiding this comment.
Suggested change
| log_pass "Verify attach/detect with multiple vdevs" | |
| log_pass "Verify attach/detach with multiple vdevs" |
|
Merged after making the suggested corrections from the review comments and dropping the changes to the upstream zstd code. |
behlendorf
added
Status: Accepted
Really thanks a lot. Crazy days for me, so I was late! |
behlendorf
pushed a commit
that referenced
this pull request
Apr 7, 2021
Correct an assortment of typos throughout the code base. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Andrea Gelmini <[email protected]> Closes #11774
adamdmoss
pushed a commit
to adamdmoss/zfs
that referenced
this pull request
Apr 10, 2021
Correct an assortment of typos throughout the code base. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Andrea Gelmini <[email protected]> Closes openzfs#11774
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Correct an assortment of typos throughout the code base. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Andrea Gelmini <[email protected]> Closes openzfs#11774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for your work.
This is just a stupid patch to fix assorted typos all around.
It passed the usual "make -j && make checkstyle && make lint"