borgbackup: initial commit

[julienmalik]

Maintainer: me
Compile tested: on Turris OS stable, based off of OpenWRT 21.02
Run tested: on Turris OS stable, based off of OpenWRT 21.02

Description:

Add package for borgbackup and its dependencies.

[hnyman]

Fails in CI.
Apparently dirty patches.
You need to run "make package/xxxx/refresh" to fix the patches. (Likely for each package)

[BKPepe]

Not sure if this is accepted here.

[julienmalik]

Thanks for the review @BKPepe, I addressed all your comments.

[BKPepe]

Ehh, your previous commit subjects were correct. It is required that it starts with the package name, otherwise Git history is going to be mess and CI will fail. Dne so 26. 11. 2022 14:47 uživatel julienmalik ***@***.***> napsal:

…

Thanks for the review @BKPepe <https://github.com/BKPepe>, I addressed all your comments. — Reply to this email directly, view it on GitHub <#19973 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7IDVCPTYMRUEE6X27JNETWKIIFVANCNFSM6AAAAAASL6CZVA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[julienmalik]

Yep spotted that just after writing. Fixed now

[julienmalik]

Some concerns :

• borg actually has a slightly more complex license (see https://metadata.ftp-master.debian.org/changelogs//main/b/borgbackup/borgbackup_1.2.2-2_copyright). lz4, zstd and xxhash are used externally, but I guess the license for crc32, crc32_slice_by_8.c, and cache_sync all apply to this package. any recommendation ?
• some trio-related packages (namely trio, async-generator, sniffio, outcome) are available under two licenses (see https://github.com/python-trio/trio/blob/master/LICENSE). I did not know how to handle that properly, so I put an |

[hnyman]

Still fails for the dirty patch.
You need to run the refresh, so that the patch gets properly formatted (and the refresh check in CI notices nothing)

if [ -s "/home/build/openwrt/build_dir/target-arc_archs_glibc/pypi/exceptiongroup-1.0.4/patches/series" ]; then (cd "/home/build/openwrt/build_dir/target-arc_archs_glibc/pypi/exceptiongroup-1.0.4"; if quilt --quiltrc=- next >/dev/null 2>&1; then quilt --quiltrc=- push -a; else quilt --quiltrc=- top >/dev/null 2>&1; fi ); fi
Applying patch 0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch
patching file setup.py

Now at patch 0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch
touch "/home/build/openwrt/build_dir/target-arc_archs_glibc/pypi/exceptiongroup-1.0.4/.quilt_checked"
Applying patch 0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch
patching file setup.py

Now at patch 0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch
Refreshed patch 0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch
mkdir -p ./patches
rm -f ./patches/* 2>/dev/null >/dev/null
'/home/build/openwrt/build_dir/target-arc_archs_glibc/pypi/exceptiongroup-1.0.4/patches/0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch' -> './patches/0001-add-setup.py-to-avoid-depending-on-flit-for-building.patch'
make[2]: Leaving directory '/feed/lang/python/python-exceptiongroup'
time: package/feeds/packages_ci/python-exceptiongroup/refresh#0.22#0.04#0.26
make[1]: Leaving directory '/home/build/openwrt'
Dirty patches detected, please refresh and review the diff
Error: Process completed with exit code 1.

[julienmalik]

I replaced my initial patch with a proper git format-patch but was not sufficient.

Now ran make package/python-exceptiongroup/refresh on top of it

Thanks for your patience :)

[commodo]

1 minor comment
rest looks good

[hnyman]

@BKPepe
Apparently you backported borgbackup to 22.03.
Please be aware that xxhash included in it may cause build failures for other packages like stress-ng.

See #19453 (comment)

[BKPepe]

Uggh... I wanted to make users happy that they are going to have it in OpenWrt 22.03. 😢 😭 Thanks for letting me know. I will address it shortly. I would notice later than you since my builds are usually running after midnight.

[commodo]

Uggh... I wanted to make users happy that they are going to have it in OpenWrt 22.03. cry sob Thanks for letting me know. I will address it shortly. I would notice later than you since my builds are usually running after midnight.

yeah, i no longer care about making users happy;
since having 2 kids around the house, trying to make them (as users) happy, is ¯\_(ツ)_/¯

anyway; i will fix stress-ng in 22.03

[commodo]

yeah, i no longer care about making users happy; since having 2 kids around the house, trying to make them (as users) happy, is ¯_(ツ)_/¯

i'm reivising the above statement;
i remembered of cases where i also tried to make users happy;

apologies for any hypocrisy (on my part)

[ynezz]

I wanted to make users happy that they are going to have it in OpenWrt 22.03

root@aba8b869ca40:/# opkg install gdb
Unknown package 'gdb'.

https://downloads.cdn.openwrt.org/releases/faillogs-22.03/aarch64_cortex-a72/base/gdb/compile.txt

Package gdb is missing dependencies for the following libraries:
libxxhash.so.0