luci-theme-bootstrap: unbound darkmode file editor #7744
Conversation
Change the file editor background in Unbound when using Bootstrap dark theme Signed-off-by: JimMatthew <[email protected]>
|
This looks OK - but all of the themes should be updated synonymously. |
I am not really sure what you mean, can expand on that? |
|
You've only updated one theme. There are 3 other.s |
|
i thought only bootstrap had a light/dark mode? |
| @@ -2621,3 +2621,7 @@ div.cbi-value var.cbi-tooltip-container, | |||
| [data-darkmode="true"] [data-page="admin-status-realtime-connections"] #view > div > div > div > svg > line[style] { | |||
| stroke: #fff!important; | |||
| } | |||
|
|
|||
| [data-darkmode="true"] .cbi-input-textarea { | |||
| background-color: var(--background-color-high); | |||
There was a problem hiding this comment.
The background color is already switched between light and dark (or well it should be). So why do we need to add another conditional define here? I guess maybe it is better to assign the background color higher up in the (parent) CSS structure?
There was a problem hiding this comment.
I think its because in the unbound package, the background is getting set manually
style>
textarea
{
background-color: #fffff0;
font-family: monospace;
}
</style>
https://github.com/openwrt/luci/blob/master/applications/luci-app-unbound/luasrc/view/unbound/css-editing.htm
There was a problem hiding this comment.
Would it not make more sense to just remove the background-color: #fffff0; ?
There was a problem hiding this comment.
yeah it would make more sense to do it that way. I just assumed the package author put it there for a reason (they wanted an ivory background) , so wasn't sure what the best thing to do would be.
|
Just remove the style overrides and let unbound use the default styles. |
Add css to make the Unbound file editor have a dark background when using Bootstrap dark mode theme.
Currently the unbound file editor has a yellowish background, even in dark mode. This makes the background dark.
I am not sure if this is the best way to do this but the change is fairly straightforward.
Let me know if this is something you are interested in or if there are any changes you would like made.
Current:
After change:
