Skip to content

luci-app-banip: rename path for Simplified/Tranditional Chinese trans… #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

luci-app-banip: rename path for Simplified/Tranditional Chinese trans… #3209

wants to merge 1 commit into from

Conversation

sotux
Copy link
Contributor

@sotux sotux commented Oct 18, 2019

As zh_Hans/zh_Hant is not the correct path for OpenWrt i18n path.

…lations

As zh_Hans/zh_Hant is not the correct path for OpenWrt i18n path.

Signed-off-by: Zheng Qian <[email protected]>
@jow-
Copy link
Contributor

jow- commented Oct 18, 2019

Thats due to the new weblate system, it dictates the paths we have to use, I think.

@aparcar - any ideas how to solve it?

@feckert feckert added the fix pull request fixing a bug label Oct 18, 2019
@aparcar
Copy link
Member

aparcar commented Oct 18, 2019

I think the problem only occurs on "newly" generated PO files as weblate uses zh_Hans instead of zh-cn. However the renamed files fitting OpenWrts i18n should still be detected as there is some support for aliases.

Therefore, I'll move all zh_Han{s,t} files and whenever there is a new component this step has to be performed again.

We could host weblate on our own and change the language definitions, however I wouldn't want to setup such a system.

@aparcar
Copy link
Member

aparcar commented Oct 18, 2019

Superseded by df6abf5

@aparcar aparcar closed this Oct 18, 2019
@aparcar
Copy link
Member

aparcar commented Oct 18, 2019

@jow- the solution is a bit unclear, the current bug boils down to this issue however other projects move on to "new language codes" a while ago. Firefox seems to discussing this just recently.

Maybe the best would be to move on to zh_Han{s,t} and add a few lines of backward compatibility to the dispatcher.lua. Sadly I'm not used to Lua so can't come up with a clean implementation for that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pull request fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants