[fix] Allowed deleting device with "deactivating" config status #949

[pandafy]

Checklist

• I have read the OpenWISP Contributing Guidelines.
• I have manually tested the changes proposed in this pull request.
• I have written new test cases for new code and/or updated existing tests for changes to existing code.
• I have updated the documentation.

Reference to Existing Issue

Fixes #949

Blockers

• Add more selenium tests
• Handle deleting multiple deactivating device

device-deletion-2025-01-02_22.31.03.mp4

[coveralls]

coverage: 98.899% (+0.7%) from 98.201%
when pulling 6e5fd68 on issues/949-delete-offline-devices
into a4c7df7 on master.

[nemesifier]

Very good work @pandafy, I just find the font-size of this box smaller than the other intermediate pages, don't you think so?

The button says "I understand the risks, delete the device", but I think it should be "I understand the risks, delete the devices".

See my other comment below.
The QA checks are failing.

[nemesifier]

I would write something like: "you can still force the deletion from OpenWISP by hitting the delete button in the device detail page after having deactivated the device or by using the bulk delete action from the device list page".

[nemesifier]

@pandafy I did some adjustments to the texts, please have one final look and let me know what you think.

[nemesifier]

FYI this test failed in this run https://github.com/openwisp/openwisp-controller/actions/runs/13018282953/job/36312736898:

ERROR: test_force_delete_multiple_devices_with_deactivating_config (openwisp_controller.config.tests.test_selenium.TestDeviceAdmin)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 592, in run
    self._callTestMethod(testMethod)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 550, in _callTestMethod
    method()
  File "/home/runner/work/openwisp-controller/openwisp-controller/openwisp_controller/config/tests/test_selenium.py", line 395, in test_force_delete_multiple_devices_with_deactivating_config
    delete_confirm.click()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/selenium/webdriver/remote/webelement.py", line 94, in click
    self._execute(Command.CLICK_ELEMENT)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/selenium/webdriver/remote/webelement.py", line 395, in _execute
    return self._parent.execute(command, params)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/selenium/webdriver/remote/webdriver.py", line 354, in execute
    self.error_handler.check_response(response)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/selenium/webdriver/remote/errorhandler.py", line 229, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementNotInteractableException: Message: element not interactable
  (Session info: chrome-headless-shell=125.0.6422.141)

[pandafy]

LGTM!

FYI this test failed in this run https://github.com/openwisp/openwisp-controller/actions/runs/13018282953/job/36312736898:

I am running this test in loop locally to check if this is another flaky test. It shouldn't be since we are WebDriver wait.

[pandafy]

I am running this test in loop locally to check if this is another flaky test. It shouldn't be since we are WebDriver wait.

I kept running that test in loop for a couple hours locally, and it didn't show up.