Skip to content

[bug] Unnecessary number of requests to get default template values #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pandafy opened this issue Apr 7, 2021 · 0 comments · Fixed by #424
Closed

[bug] Unnecessary number of requests to get default template values #423

pandafy opened this issue Apr 7, 2021 · 0 comments · Fixed by #424
Assignees
@pandafy
Labels
bug Important Higher priority or release blocker

Comments

@pandafy
Copy link
Member

pandafy commented Apr 7, 2021

How to replicate:

  1. Create an enabled by default template
  2. Open device add page /admin/config/device/add/
  3. Open web debugger too and monitor the requests made
  4. Add a configuration objects and change the Backend field a couple of times

Actual Result

You will observe that the number of requests will increase with the number of change operations

Expected Result

Only one request should be made after the change operation.
Hnet-image (2)
@pandafy pandafy added bug Important Higher priority or release blocker labels Apr 7, 2021
@pandafy pandafy self-assigned this Apr 7, 2021
@pandafy pandafy changed the title [bug] Unnecessary number of requests to get default templates [bug] Unnecessary number of requests to get default template values Apr 7, 2021
pandafy added a commit that referenced this issue Apr 7, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
4b860f2 
#423

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 7, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
d3bf870 
#423

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 7, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
faf951c 
#423

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 7, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
a8f54e7 
#423

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
@pandafy pandafy mentioned this issue Apr 7, 2021
Merged
pandafy added a commit that referenced this issue Apr 7, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
e1d40d9 
#423

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
nemesifier pushed a commit that referenced this issue Apr 8, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
3b955a2 
#423 (#424)

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 9, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
c8b456f 
#423 (#424)

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 9, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
d7ec80e 
#423 (#424)

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 9, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
dbd9051 
#423 (#424)

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
pandafy added a commit that referenced this issue Apr 9, 2021
@pandafy
[fix] Fixed multiple requests made for fetching default template values
2b6d090 
#423 (#424)

The JS code made multiple HTTP request for fetching default template
values when any of organization or backend field were updated.

Fixed it by not triggering "click" event of sortedm2m-items and manaully
updating primary keys of templates using JS.

Closes #423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pandafy pandafy

Labels
bug Important Higher priority or release blocker
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
1 participant
@pandafy