Skip to content

[bug] Unsaved changes JS broken when device have geographic location defined #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nemesifier opened this issue Feb 18, 2021 · 1 comment · Fixed by #411
Closed

[bug] Unsaved changes JS broken when device have geographic location defined #388

nemesifier opened this issue Feb 18, 2021 · 1 comment · Fixed by #411
Labels
bug Important Higher priority or release blocker

Comments

@nemesifier
Copy link
Member

How to replicate:

  • create a device
  • go to the map tab and create a new location
  • save and open the device page again
  • now go back to the device list

Expected result:

  • device list page is opened normally

Actual result:

  • unsaved changes JS is triggered and user is asked for confirmation (Changes you made may not be saved.)

The unsaved changes JS should not be triggered by this.
@nemesifier nemesifier added bug Important Higher priority or release blocker labels Feb 18, 2021
@jalajcodes
Copy link

I am working on it.

jalajcodes added a commit to jalajcodes/openwisp-controller that referenced this issue Mar 13, 2021
@jalajcodes
[unsaved_changes.js] Ignore device location field openwisp#388
b120d7b 
unsaved changes js is triggered when device have geographic location defined,
fixed it by ignoring the input field for device location

Fixes openwisp#388
jalajcodes added a commit to jalajcodes/openwisp-controller that referenced this issue Mar 13, 2021
@jalajcodes
[unsaved_changes.js] Ignore device location field openwisp#388
f0d38ef 
unsaved changes js is triggered when device have geographic location defined,
fixed it by ignoring the input field for device location

Fixes openwisp#388
@jalajcodes jalajcodes mentioned this issue Mar 13, 2021
Closed
@nemesifier nemesifier mentioned this issue Mar 25, 2021
Merged
pandafy pushed a commit that referenced this issue Apr 9, 2021
@nemesifier @pandafy
[fix] Fixed unsaved_changes.js when location is present #388
1dee955 
Location geometry was not being parsed from JSON and hence
the geometry JSON representation had some slight differences
which where triggering the unsaved changes alert.

I took advantage to simplify the code and to fix the
non camelcase functions and variables in this part of the code.

I also updated a global variable name strating with _njc
(netjsonconfig) to owc (openwisp-controller).

Fixes #388
pandafy pushed a commit that referenced this issue Apr 9, 2021
@nemesifier @pandafy
[fix] Fixed unsaved_changes.js when location is present #388
ed5e6b8 
Location geometry was not being parsed from JSON and hence
the geometry JSON representation had some slight differences
which where triggering the unsaved changes alert.

I took advantage to simplify the code and to fix the
non camelcase functions and variables in this part of the code.

I also updated a global variable name strating with _njc
(netjsonconfig) to owc (openwisp-controller).

Fixes #388
pandafy pushed a commit that referenced this issue Apr 9, 2021
@nemesifier @pandafy
[fix] Fixed unsaved_changes.js when location is present #388
b9f676c 
Location geometry was not being parsed from JSON and hence
the geometry JSON representation had some slight differences
which where triggering the unsaved changes alert.

I took advantage to simplify the code and to fix the
non camelcase functions and variables in this part of the code.

I also updated a global variable name strating with _njc
(netjsonconfig) to owc (openwisp-controller).

Fixes #388
pandafy pushed a commit that referenced this issue Apr 9, 2021
@nemesifier @pandafy
[fix] Fixed unsaved_changes.js when location is present #388
e188dfc 
Location geometry was not being parsed from JSON and hence
the geometry JSON representation had some slight differences
which where triggering the unsaved changes alert.

I took advantage to simplify the code and to fix the
non camelcase functions and variables in this part of the code.

I also updated a global variable name strating with _njc
(netjsonconfig) to owc (openwisp-controller).

Fixes #388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Important Higher priority or release blocker
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
2 participants
@nemesifier @jalajcodes