Skip to content

[bug] Setting template organization puts devices in perennial "modified" state #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nemesifier opened this issue Feb 12, 2019 · 1 comment · Fixed by #787
Closed

[bug] Setting template organization puts devices in perennial "modified" state #213

nemesifier opened this issue Feb 12, 2019 · 1 comment · Fixed by #787
Labels
bug

Comments

@nemesifier
Copy link
Member

I observed something that looks like a bug:

  • a template gets its organization changed
  • related devices go into "modified" state
  • since the configuration checksum has not changed, devices won't download the new configuration and will remain in "modified" state

First, the bug needs to be verified, then a possible solution would be to to change status of the related devices only when the configuration content of a template is changed.
@nemesifier nemesifier transferred this issue from openwisp/django-netjsonconfig Jun 30, 2020
@pniaps
Copy link
Member

pniaps commented Sep 13, 2021

The same happens if I add a configuration variable wich is not used, the checksum is not changed, but configuration has been changed to "modified"

Maybe a good solution would be to change to "modified" only if checksum has changed.

@nemesifier nemesifier added the bug label May 31, 2023
@nemesifier nemesifier changed the title Setting template organization puts devices in perennial "modified" state [bug] Setting template organization puts devices in perennial "modified" state May 31, 2023
pandafy added a commit that referenced this issue Jul 6, 2023
@pandafy
[fix] Fixed updating template puts devices in perennial "modified" st…
642c0c0 
…ate #213

The status of related Config objects will only be updated if
the checksum of template's configuration changes.

Closes #213
pandafy added a commit that referenced this issue Jul 6, 2023
@pandafy
[fix] Fixed updating template puts devices in perennial "modified" st…
5c07f07 
…ate #213

The status of related Config objects will only be updated if
the checksum of template's configuration changes.

Closes #213
@pandafy pandafy mentioned this issue Jul 6, 2023
Merged
pandafy added a commit that referenced this issue Jul 6, 2023
@pandafy
[fix] Fixed updating template puts devices in perennial "modified" st…
691ea08 
…ate #213

The status of related Config objects will only be updated if
the checksum of template's configuration changes.

Closes #213
pandafy added a commit that referenced this issue Jul 6, 2023
@pandafy
[fix] Fixed updating template puts devices in perennial "modified" st…
09bdb41 
…ate #213

The status of related Config objects will only be updated if
the checksum of template's configuration changes.

Closes #213
pandafy added a commit that referenced this issue Jul 10, 2023
@pandafy
[fix] Fixed updating template puts devices in perennial "modified" st…
f7724bf 
…ate #213

The status of related Config objects will only be updated if
the checksum of template's configuration changes.

Closes #213
nemesifier pushed a commit that referenced this issue Jul 12, 2023
@pandafy
[fix] Fixed perennial "modified" state #213
4eec323 
The status of Config objects will only be updated if
the checksum changes, whether it's because of a
change in the config, device or any related templates.

Closes #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
OpenWISP Contributor's Board
Archived in project
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
2 participants
@nemesifier @pniaps