Skip to content

(chore) rust 1.84 update, dependency updates and workspace deps usage #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 26, 2025

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Dec 31, 2024

Updates a bunch of major dep versions (notably askar), updates minor versions in the lockfile with cargo update, and move alot of common dependencies to workspace deps.

Note that #1318 includes some of the same changes for workspace, however this PR adds rust updates and dep updates in addition. As such this PR would close #1318. My bad for not coordinating these PRs better

Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
@gmulhearn gmulhearn changed the title (chore) dependency updates and workspace deps usage (chore) rust 1.83 update, dependency updates and workspace deps usage Jan 1, 2025
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
@gmulhearn gmulhearn changed the title (chore) rust 1.83 update, dependency updates and workspace deps usage (chore) rust 1.84 update, dependency updates and workspace deps usage Feb 13, 2025
Signed-off-by: gmulhearn <[email protected]>
@gmulhearn gmulhearn marked this pull request as ready for review February 13, 2025 13:01
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
@gmulhearn
Copy link
Contributor Author

@JamesKEbert as discussed, i'm now using hyperledger indy-vdr main commit instead of anonyome fork: git = "https://github.com/hyperledger/indy-vdr.git", rev = "b4dc08b"

Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I flagged a number of spots that some dependencies weren't pointing to the workspace, but I wasn't sure if that was intentional or not. 🤷‍♂️
Could you update the README.MD to indicate our higher rust version support?

@gmulhearn
Copy link
Contributor Author

@JamesKEbert ah yeah I should've explained my method. I was moving deps with more than 1 usage into the workspace. However maybe it's simpler just to move everything. The latter is probs easier to maintain, whatcha think?

@JamesKEbert
Copy link
Contributor

Ah yeah that makes more sense 😆 I lean towards moving them all, as I could definitely see the situation where we add a new dependency to a crate but don't realize it's already present in a different crate. That's obviously not hard to fix, but I don't see a big benefit of not adding them to the workspace file.
Plus that way you know that all dependency versions for any given crate will be in the workspace file, not split between the two files

@gmulhearn
Copy link
Contributor Author

@JamesKEbert kk agreed. I'll revise tonight

Signed-off-by: gmulhearn <[email protected]>
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- good stuff :)

@JamesKEbert JamesKEbert merged commit 74621af into main Feb 26, 2025
20 checks passed
@JamesKEbert JamesKEbert deleted the gm/update-askar branch February 26, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants