-
Notifications
You must be signed in to change notification settings - Fork 85
(chore) rust 1.84 update, dependency updates and workspace deps usage #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
aries/misc/anoncreds_types/src/data_types/messages/credential.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
@JamesKEbert as discussed, i'm now using hyperledger indy-vdr main commit instead of anonyome fork: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! I flagged a number of spots that some dependencies weren't pointing to the workspace, but I wasn't sure if that was intentional or not. 🤷♂️
Could you update the README.MD to indicate our higher rust version support?
@JamesKEbert ah yeah I should've explained my method. I was moving deps with more than 1 usage into the workspace. However maybe it's simpler just to move everything. The latter is probs easier to maintain, whatcha think? |
Ah yeah that makes more sense 😆 I lean towards moving them all, as I could definitely see the situation where we add a new dependency to a crate but don't realize it's already present in a different crate. That's obviously not hard to fix, but I don't see a big benefit of not adding them to the workspace file. |
@JamesKEbert kk agreed. I'll revise tonight |
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- good stuff :)
Updates a bunch of major dep versions (notably askar), updates minor versions in the lockfile with
cargo update
, and move alot of common dependencies to workspace deps.Note that #1318 includes some of the same changes for workspace, however this PR adds rust updates and dep updates in addition. As such this PR would close #1318. My bad for not coordinating these PRs better