Skip to content

Update QR to pending when phone camera is used to scan QR #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Feb 19, 2025

This PR resolves #615

2025-02-19_15-30-43.mp4

@coveralls
Copy link

coveralls commented Feb 19, 2025

Pull Request Test Coverage Report for Build 13424328739

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.272%

Totals Coverage Status
Change from base Build 13422541191: 0.0%
Covered Lines: 689
Relevant Lines: 808

💛 - Coveralls

@Gavinok Gavinok requested review from loneil and esune and removed request for loneil February 19, 2025 23:33
Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ran locally and tried the 3 flavors of login on Android and iOS

@esune esune merged commit fde9911 into openwallet-foundation:main Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback on the QR page when scanning with device camera (instead of App)
4 participants