Skip to content

Migrate to Poetry 2.0 #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2025
Merged

Migrate to Poetry 2.0 #720

merged 4 commits into from
Feb 15, 2025

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Feb 11, 2025

This PR adds support for Poetry 2.0 resolving #701

@Gavinok
Migrate to Poetry 2.0
73706de 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Upgrate poetry version in unit tests
64b9263 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
added the --no-root arg
c0289fe 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok Gavinok requested review from loneil and esune February 11, 2025 21:00
esune
esune previously approved these changes Feb 12, 2025
View reviewed changes
loneil
loneil requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run a poetry update and commit the changes to the lock file with this.

That'll probably catch up #719 as well

@Gavinok
Update Lock File
d55db08 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13293733103

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on poetry-2.0 at 85.254%
Totals Coverage Status
Change from base Build 13248313025: 85.3%
Covered Lines: 688
Relevant Lines: 807
💛 - Coveralls

@esune esune requested a review from loneil February 13, 2025 19:39
@esune esune merged commit 26fa6a0 into openwallet-foundation:main Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

@loneil loneil loneil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gavinok @coveralls @esune @loneil