-
Notifications
You must be signed in to change notification settings - Fork 2
chore(xtest): better skew version summaries #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(xtest): better skew version summaries #287
Conversation
vibe coded with gpt4o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
xtest/setup-cli-tool/action.yaml:62
- The error check is using the field '.error', but the version resolution script returns errors in the field 'err'. Please update the jq filter to use '.err != null'.
if echo "$version_info" | jq -e '.[] | select(.error != null)' > /dev/null; then
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
xtest/sdk/scripts/resolve-version.py:267
- The variable 'sdk_url' is referenced in the error message but is not defined in this scope. Consider defining it or removing it from the message.
raise ValueError(f"Tag [{version}] not found in [{sdk_url}]")
Prints out a full matrix of what components are under test, including version information if available and links back to pull requests and commits viewable in github.
vibe coded with gpt4o