Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support onConfigUpdate hook when registering services #1992

Merged
merged 30 commits into from
Apr 14, 2025

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Mar 18, 2025

Proposed Changes

Enhance config management and service registration to allow services to react to configuration updates, and for configuration updates to come from config loaders that may retrieve it from a wide variety of sources.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@jakedoublev jakedoublev marked this pull request as ready for review March 26, 2025 18:30
@jakedoublev jakedoublev requested review from a team as code owners March 26, 2025 18:30
@jakedoublev jakedoublev requested review from a team as code owners March 26, 2025 18:30
@jakedoublev jakedoublev changed the title feat(core): onConfigUpdate hook in services feat(core): support onConfigUpdate hook when registering services Mar 26, 2025
@jakedoublev jakedoublev enabled auto-merge April 10, 2025 22:03
Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.059 ms 0.028 ms 0.094 ms
rewrap-nanotdf 4954 416.263 ms 45.176 ms 1056.771 ms
rewrap-tdf3 5001 445.475 ms 43.505 ms 926.557 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 379.903405ms
Throughput 263.22 requests/second

Copy link
Member

@elizabethhealy elizabethhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kas and authorization changes lgtm

@jakedoublev jakedoublev added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 366d4dc Apr 14, 2025
24 checks passed
@jakedoublev jakedoublev deleted the feat/config-loading branch April 14, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants