Skip to content

Opentable specific mods #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

travees
Copy link

@travees travees commented Jul 12, 2016

Re-add OpenTable mods after upstream sync

travees added 2 commits July 11, 2016 17:34
- Allow for exhibitor use
- Use archive module for tarball installs
- Update specs
- Add parameters to README
@@ -106,7 +106,8 @@
}
}

if $exhibitor_manaaged == 'false' {
if $exhibitor_managed == false {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using stdlib/validate_bool

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is validated in init.pp.
Preferable to move it into config.pp?

travees added 3 commits July 25, 2016 14:23
- Require $install_method to be either 'package' or 'archive'
- Pass in optional archive checksum instead of getting from external URL when using
  archive install method
spec didn't like unquoted hash keys
- Move exec conditional script into its own file
- Do some validation of znode path
- shellquote for safety
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants